Fix the example in documentation for get_dremel_data()
#17242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhaseeb123
commented
Nov 4, 2024
mhaseeb123
added
2 - In Progress
davidwendt
approved these changes
Nov 5, 2024
mhaseeb123
commented
Nov 5, 2024
| * col = {[], [[], [1, 2, 3], [4, 5]], [[]]} | ||
| * dremel_offsets = { 0, 1, 7, 8} | ||
| * def_levels = { 0 1, 2, 2, 2, 2, 2, 1 } | ||
| * rep_levels = { 0, 0, 1, 2, 2, 1, 2, 0 } | ||
| * ``` | ||
| * | ||
| * Since repetition and definition levels arrays contain a value for each empty list, the size of |
There was a problem hiding this comment.
Reviewers: Would love an extra set of eyes at the explanation of the algorithm at L120-151 if you could. I looked into it while making the edits and the explanation looked fine to me so I didn't make any changes. Thanks!
There was a problem hiding this comment.
Looks good, I'm just confused as to why we included the algorithm description in the public header :)
Not a concern for this PR
mhaseeb123
added
3 - Ready for Review
vuule
requested changes
Nov 6, 2024
Co-authored-by: Vukasin Milovanovic <[email protected]>
mhaseeb123
added
4 - Needs Review
vuule
approved these changes
Nov 6, 2024
mhaseeb123
added
5 - Ready to Merge
|
/merge |
mythrocks
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #11396. Fixes the example in the documentation of
get_dremel_data()Checklist