Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add io.text APIs to pylibcudf #17232

Merged
merged 13 commits into from
Nov 7, 2024
Merged

Add io.text APIs to pylibcudf #17232

merged 13 commits into from
Nov 7, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Nov 1, 2024
@mroeschke mroeschke self-assigned this Nov 1, 2024
@mroeschke mroeschke requested a review from a team as a code owner November 1, 2024 00:35
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Nov 1, 2024
@mroeschke mroeschke mentioned this pull request Nov 1, 2024
Closed
wence-
wence- requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions

python/pylibcudf/pylibcudf/io/text.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/io/text.pyx Outdated Show resolved Hide resolved
wence-
wence- approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c209dae into rapidsai:branch-24.12 Nov 7, 2024
102 checks passed
@mroeschke mroeschke deleted the pylibcudf/io/text branch November 7, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

@mroeschke mroeschke

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @wence- @vyasr