Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsanitized nulls from input strings columns in reduction gtests #17202

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Remove unsanitized nulls from input strings columns in reduction gtests #17202

merged 3 commits into from
Oct 31, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Input strings column containing unsanitized nulls may result in undefined behavior.
This PR fixes the input data to not include string characters in null rows in gtests for REDUCTION_TESTS.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Oct 29, 2024
@davidwendt davidwendt self-assigned this Oct 29, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 30, 2024
@davidwendt davidwendt marked this pull request as ready for review October 30, 2024 13:08
@davidwendt davidwendt requested a review from a team as a code owner October 30, 2024 13:08
bdice
bdice requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a small issue after approving. We are mixing null/NULL in the same tests. Can we be consistent?

cpp/tests/reductions/scan_tests.cpp Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 01cfcff into rapidsai:branch-24.12 Oct 31, 2024
103 checks passed
@davidwendt davidwendt deleted the unsan-nulls-red-gtests branch October 31, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@lamarrr lamarrr Awaiting requested review from lamarrr lamarrr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @karthikeyann