Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified binary_ops and ast benchmarks parameter names #17200

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

lamarrr
Copy link
Contributor

@lamarrr lamarrr commented Oct 29, 2024

Description

This merge request unifies the parameter names of the AST and BINARYOP benchmark suites and makes it easier to perform parameter sweeps and compare the outputs of both benchmarks.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Sorry, something went wrong.

@lamarrr lamarrr requested a review from a team as a code owner October 29, 2024 17:09
@lamarrr lamarrr requested review from ttnghia and davidwendt October 29, 2024 17:09
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 29, 2024
@lamarrr lamarrr added feature request New feature or request improvement Improvement / enhancement to an existing function labels Oct 29, 2024
@lamarrr lamarrr added non-breaking Non-breaking change and removed feature request New feature or request labels Oct 29, 2024
@lamarrr
Copy link
Contributor Author

lamarrr commented Oct 29, 2024

/merge

@rapids-bot rapids-bot bot merged commit 52d7e63 into rapidsai:branch-24.12 Oct 29, 2024
102 checks passed
@lamarrr lamarrr deleted the ast-binops-params-naming branch October 29, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants