Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to_parquet append behavior with global metadata file #17198

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Fix to_parquet append behavior with global metadata file #17198

merged 5 commits into from
Oct 30, 2024

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Oct 29, 2024 •
edited
Loading

Description

Closes #17177

When appending to a parquet dataset with Dask cuDF, the original metadata must be converted from pq.FileMetaData to bytes before it can be passed down to cudf.io.merge_parquet_filemetadata.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 29, 2024
@rjzamora rjzamora self-assigned this Oct 29, 2024
@rjzamora rjzamora requested a review from a team as a code owner October 29, 2024 16:07
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 29, 2024
madsbk
madsbk approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only have a minor suggestion

python/dask_cudf/dask_cudf/io/parquet.py Show resolved Hide resolved
@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 30, 2024
@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 5a6d177 into rapidsai:branch-24.12 Oct 30, 2024
100 checks passed
@rjzamora rjzamora deleted the fix/to-parquet-append-metadata branch October 30, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

Assignees

@rjzamora rjzamora

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] dask-cudf.to_parquet(write_metadata_file=True, append=True) fails
2 participants
@rjzamora @madsbk