Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move nvtext ngrams benchmarks to nvbench #17173

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Move nvtext ngrams benchmarks to nvbench #17173

merged 2 commits into from
Oct 25, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Moves the nvtext::generate_ngrams and nvtext::generate_character_ngrams benchmarks from google-bench to nvbench.
Target parameters are exposed to help with profiling.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 24, 2024
@davidwendt davidwendt self-assigned this Oct 24, 2024
@davidwendt davidwendt requested a review from a team as a code owner October 24, 2024 20:39
@github-actions github-actions bot added the CMake CMake build issue label Oct 24, 2024
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0bb699e into rapidsai:branch-24.12 Oct 25, 2024
102 checks passed
@davidwendt davidwendt deleted the nvbench-ngrams branch October 25, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @PointKernel