Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CSV writer to pylibcudf #17163

Merged
merged 40 commits into from
Nov 21, 2024
Merged

Migrate CSV writer to pylibcudf #17163

merged 40 commits into from
Nov 21, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 24, 2024 •
edited
Loading

Description

Apart of #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Oct 24, 2024
@Matt711 Matt711 self-assigned this Oct 24, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Oct 24, 2024
@Matt711 Matt711 changed the title [WIP] Migrate CSV writer to pylibcudf Migrate CSV writer to pylibcudf Nov 6, 2024
@Matt711 Matt711 marked this pull request as ready for review November 6, 2024 18:15
@Matt711 Matt711 requested a review from a team as a code owner November 6, 2024 18:15
@Matt711 Matt711 added the 3 - Ready for Review Ready for review by team label Nov 18, 2024
@Matt711 Matt711 requested review from wence- and mroeschke November 18, 2024 21:37
wence-
wence- requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions

python/pylibcudf/pylibcudf/io/csv.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/io/csv.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/io/types.pyx Show resolved Hide resolved
python/pylibcudf/pylibcudf/io/types.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/io/types.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/conftest.py Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/io/csv.pyi Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/io/csv.pyx Outdated
return csv_options


def write_csv(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this (should this? @vyasr) be a cpdef function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We've been cpdef'ing them, so I did it here too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good practice to do it consistently everywhere to enable full Cython usage. For I/O it's probably less important in the grand scheme of things since that shouldn't propagate bad typing afterwards in any way, but consistency helps.

@Matt711 Matt711 mentioned this pull request Nov 20, 2024
Merged
3 tasks
vyasr
vyasr approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions, but nothing blocking. Looks great overall.

python/cudf/cudf/_lib/csv.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/csv.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/io/csv.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/conftest.py Show resolved Hide resolved
@Matt711
Copy link
Contributor Author

Matt711 commented Nov 21, 2024

/merge

1 similar comment
@Matt711
Copy link
Contributor Author

Matt711 commented Nov 21, 2024

/merge

@Matt711 Matt711 requested a review from wence- November 21, 2024 12:10
@rapids-bot rapids-bot bot merged commit f54c1a5 into rapidsai:branch-24.12 Nov 21, 2024
107 checks passed
rapids-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@Matt711
Remove unused IO utilities from cudf python (#17374)
0f5d4b9 
Removes unused IO utilities from cuDF Python. Depends on #17163 #16042 #17252 #17263

Authors:
  - Matthew Murray (https://github.com/Matt711)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #17374
@Matt711 Matt711 mentioned this pull request Dec 10, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@vyasr vyasr vyasr approved these changes

@mroeschke mroeschke mroeschke approved these changes

@wence- wence- wence- approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
3 - Ready for Review Ready for review by team feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Matt711 @wence- @vyasr @mroeschke @davidwendt