Upgrade to polars 1.11 in cudf-polars #17154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, implement inequality joins by translation to cross-join + filter. This is the minimum necessary for things to work, and we will use ast-based conditional and mixed joins in a followup.
Now that the dynamic groupby options are exposed, we can raise without heuristics. Partially addresses rapidsai#17144
In particular: - join_where + slicing - tests of slicing for left and cross joins
github-actions
bot
added
Python
bdice
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
One small typo fix, otherwise all looks good. Thanks for updating the conda recipe. We will need to keep conda/recipes/cudf-polars/meta.yaml in sync with dependencies.yaml because we do not have a way to manage conda recipes using rapids-dependency-file-generator.
msarahan
approved these changes
Oct 23, 2024
Co-authored-by: Bradley Dice <[email protected]>
wence-
added
improvement
|
Breaking change purely because it bumps the minimum required polars version. |
|
/merge |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Polars 1.11 is out, with slight updates to the IR, so we can correctly raise for dynamic groupbys and see inequality joins.
These changes adapt to that and do a first pass at supporting inequality joins (by translating to cross + filter). A followup (#17000) will use libcudf's conditional joins.
Checklist