Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing developer guide int_64_t to int64_t #17130

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Changing developer guide int_64_t to int64_t #17130

merged 1 commit into from
Oct 19, 2024

Conversation

hyperbolic2346
Copy link
Contributor

Description

Fixes #17129

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@hyperbolic2346
changing int_64_t to int64_t
ae70064 
Signed-off-by: Mike Wilson <[email protected]>
@hyperbolic2346 hyperbolic2346 requested a review from a team as a code owner October 18, 2024 20:57
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 18, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 18, 2024
@ttnghia ttnghia added the non-breaking Non-breaking change label Oct 18, 2024
@hyperbolic2346 hyperbolic2346 added 3 - Ready for Review Ready for review by team doc Documentation labels Oct 18, 2024
@ttnghia ttnghia added bug Something isn't working and removed bug Something isn't working labels Oct 18, 2024
@ttnghia
Copy link
Contributor

ttnghia commented Oct 18, 2024

/ok to test

bdice
bdice approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steps taken to verify documentation is incorrect
Spark Rapids Team Trivia consensus

🤣 We love it. We'll accept a trivia-l PR to correct this.

@ttnghia
Copy link
Contributor

ttnghia commented Oct 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit fdd2b26 into rapidsai:branch-24.12 Oct 19, 2024
102 checks passed
@hyperbolic2346 hyperbolic2346 deleted the mwilson/int64_fix branch October 21, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@abellina abellina abellina approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Developer doc incorrectly says int_64_t is a type
6 participants
@hyperbolic2346 @ttnghia @abellina @bdice @mhaseeb123 @davidwendt