Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the Parquet reader's wide lists tables GTest by default #17120

Conversation

mhaseeb123
Copy link
Member

@mhaseeb123 mhaseeb123 commented Oct 17, 2024

Description

This PR disables Parquet reader's wide lists table gtest by default as it takes several minutes to complete with memcheck. See the discussion on PR #17059 (this comment) for more context.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 17, 2024
@mhaseeb123 mhaseeb123 self-assigned this Oct 17, 2024
@mhaseeb123 mhaseeb123 requested a review from davidwendt October 17, 2024 23:55
@mhaseeb123 mhaseeb123 added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 17, 2024
@mhaseeb123 mhaseeb123 marked this pull request as ready for review October 17, 2024 23:56
@mhaseeb123 mhaseeb123 requested a review from a team as a code owner October 17, 2024 23:56
@mhaseeb123 mhaseeb123 changed the title Disable the widetable gtest by default Disable the Parquet reader's Wide-list tables GTest by default Oct 17, 2024
@mhaseeb123 mhaseeb123 changed the title Disable the Parquet reader's Wide-list tables GTest by default Disable the Parquet reader's wide lists tables GTest by default Oct 17, 2024
@mhaseeb123 mhaseeb123 added the improvement Improvement / enhancement to an existing function label Oct 17, 2024
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@vyasr
Copy link
Contributor

vyasr commented Oct 18, 2024

Is there any faster way to test this so that we don't lose coverage? Alternatively, is there a way to only skip this in memcheck tests?

@mhaseeb123
Copy link
Member Author

mhaseeb123 commented Oct 18, 2024

Is there any faster way to test this so that we don't lose coverage? Alternatively, is there a way to only skip this in memcheck tests?

Unfortunately no, we need to go beyond 2B keys. I am not aware if we have a mechanism for that, but I would be happy to do it that way instead.

@vuule
Copy link
Contributor

vuule commented Oct 18, 2024

Is there a way to run tests so that this test is included as well?

@mhaseeb123
Copy link
Member Author

mhaseeb123 commented Oct 18, 2024

Is there a way to run tests so that this test is included as well?

If running locally, one can do something like ./PARQUET_TEST --gtest_also_run_disabled_tests

@mhaseeb123
Copy link
Member Author

mhaseeb123 commented Oct 18, 2024

Had an offline discussion with @davidwendt and we agreed that it's best for now to keep this test disabled and not add to CI burden like we do for some other (increasing number of) gtests due to similar reasons. We can in the future devise a way to enable these tests in an efficient manner.

Alternatively, is there a way to only skip this in memcheck tests?

According to David, there is a way to skip it in just memcheck but it is mainly for working around temporary compute-sanitizer bugs not to avoid testing our code.

@mhaseeb123
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit e242dce into rapidsai:branch-24.12 Oct 18, 2024
122 checks passed
@mhaseeb123 mhaseeb123 deleted the fea/disable-wide-lists-table-test-by-default branch October 18, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Reliability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants