-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the Parquet reader's wide lists tables GTest by default #17120
Disable the Parquet reader's wide lists tables GTest by default #17120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this.
Is there any faster way to test this so that we don't lose coverage? Alternatively, is there a way to only skip this in memcheck tests? |
Unfortunately no, we need to go beyond 2B keys. I am not aware if we have a mechanism for that, but I would be happy to do it that way instead. |
Is there a way to run tests so that this test is included as well? |
If running locally, one can do something like |
Had an offline discussion with @davidwendt and we agreed that it's best for now to keep this test disabled and not add to CI burden like we do for some other (increasing number of) gtests due to similar reasons. We can in the future devise a way to enable these tests in an efficient manner.
According to David, there is a way to skip it in just memcheck but it is mainly for working around temporary |
/merge |
Description
This PR disables Parquet reader's wide lists table gtest by default as it takes several minutes to complete with memcheck. See the discussion on PR #17059 (this comment) for more context.
Checklist