Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate NVText Byte Pair Encoding APIs to pylibcudf #17101

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Migrate NVText Byte Pair Encoding APIs to pylibcudf #17101

merged 6 commits into from
Oct 31, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 16, 2024 •
edited
Loading

Description

Apart of #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Oct 16, 2024
@Matt711 Matt711 self-assigned this Oct 16, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue pylibcudf Issues specific to the pylibcudf package labels Oct 16, 2024
@Matt711 Matt711 mentioned this pull request Oct 16, 2024
Closed
@Matt711 Matt711 marked this pull request as ready for review October 16, 2024 10:01
@Matt711 Matt711 requested a review from a team as a code owner October 16, 2024 10:01
vyasr
vyasr approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change a couple of things here, but assuming you don't have any objection to those changes I don't need to review again.

python/pylibcudf/pylibcudf/nvtext/byte_pair_encode.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/core/byte_pair_encoding.py Outdated Show resolved Hide resolved
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 31, 2024

/merge

@rapids-bot rapids-bot bot merged commit 0db2463 into rapidsai:branch-24.12 Oct 31, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
CMake CMake build issue feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt711 @vyasr