Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move flatten_single_pass_aggs to its own TU #17053

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Move flatten_single_pass_aggs to its own TU #17053

merged 3 commits into from
Oct 11, 2024

Conversation

PointKernel
Copy link
Member

Description

Part of splitting the original bulk shared memory groupby PR #16619.

This PR separates flatten_single_pass_aggs into its own translation unit without making any code modifications.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 10, 2024
@PointKernel PointKernel self-assigned this Oct 10, 2024
@PointKernel PointKernel requested review from a team as code owners October 10, 2024 21:15
KyleFromNVIDIA
KyleFromNVIDIA approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved trivial CMake changes

shrshi
shrshi approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@shrshi shrshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

karthikeyann
karthikeyann approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit fea87cb into rapidsai:branch-24.12 Oct 11, 2024
102 checks passed
@PointKernel PointKernel deleted the flatten-aggs-cleanups branch October 11, 2024 19:39
@PointKernel PointKernel mentioned this pull request Oct 21, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@davidwendt davidwendt davidwendt approved these changes

@shrshi shrshi shrshi approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@JayjeetAtGithub JayjeetAtGithub Awaiting requested review from JayjeetAtGithub JayjeetAtGithub is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@PointKernel PointKernel

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PointKernel @karthikeyann @shrshi @davidwendt @KyleFromNVIDIA