Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change 'CSV' to 'csv' in python/custreamz/README.md to match kafka.py #17041

Merged
merged 1 commit into from
Oct 11, 2024
Merged

docs: change 'CSV' to 'csv' in python/custreamz/README.md to match kafka.py #17041

merged 1 commit into from
Oct 11, 2024

Conversation

a-hirota
Copy link
Contributor

Description

This PR corrects a typo in the python/custreamz/README.md file by changing the uppercase 'CSV' to lowercase 'csv'. This change aligns the documentation with the message_format options defined in python/custreamz/custreamz/kafka.py, ensuring consistency across the codebase.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@a-hirota a-hirota requested a review from a team as a code owner October 10, 2024 15:54
@a-hirota a-hirota requested review from isVoid and Matt711 October 10, 2024 15:54
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 10, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 10, 2024
@vyasr
Copy link
Contributor

vyasr commented Oct 10, 2024

/ok to test

@vyasr vyasr added doc Documentation non-breaking Non-breaking change labels Oct 10, 2024
vyasr
vyasr approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

Matt711
Matt711 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Matt711
Copy link
Contributor

Matt711 commented Oct 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit 0b840bb into rapidsai:branch-24.12 Oct 11, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@Matt711 Matt711 Matt711 approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-hirota @vyasr @Matt711