Add conda recipe for cudf-polars #17037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
wence-
requested changes
Oct 16, 2024
python/cudf_polars/.coveragerc
Outdated
Comment on lines
1
to
3
| # Configuration file for Python coverage tests | ||
| [run] | ||
| source = cudf_polars |
There was a problem hiding this comment.
We already do some configuration of coverage in pyproject.toml. Can this configuration also go there (I suppose in a [tool.coverage.run] section?
There was a problem hiding this comment.
We may not even need a separate section for this. I pushed 1a2be0d to try using pyproject.toml without defining the [tool.coverage.run] source.
| @@ -96,7 +96,7 @@ def test_bool_agg(agg, request): | |||
| assert_gpu_result_equal(q, check_exact=False) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("cum_agg", expr.UnaryFunction._supported_cum_aggs) | |||
| @pytest.mark.parametrize("cum_agg", sorted(expr.UnaryFunction._supported_cum_aggs)) | |||
There was a problem hiding this comment.
For reference, this was necessary to make multi-worker testing operate correctly. The frozenset had a different order on each worker, so pytest failed because the test collection didn't agree across all workers.
Matt711
approved these changes
Oct 16, 2024
Co-authored-by: Matthew Murray <[email protected]>
jameslamb
approved these changes
Oct 16, 2024
|
I confirmed that coverage is working: |
wence-
approved these changes
Oct 17, 2024
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/integration
that referenced
this pull request
Oct 18, 2024
Follow-up to rapidsai/cudf#17037. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - James Lamb (https://github.com/jameslamb) URL: #732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds conda recipes for
cudf-polars. This is needed to getcudf-polarsinto RAPIDS Docker containers and therapidsmetapackage.Closes #16816.
Checklist