Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Min Hashing APIs to pylibcudf #17021

Merged
merged 15 commits into from
Oct 11, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 8, 2024

Description

Apart of #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 self-assigned this Oct 8, 2024
@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Oct 8, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue pylibcudf Issues specific to the pylibcudf package and removed feature request New feature or request non-breaking Non-breaking change labels Oct 8, 2024
@Matt711 Matt711 marked this pull request as ready for review October 9, 2024 01:01
@Matt711 Matt711 requested a review from a team as a code owner October 9, 2024 01:01
@Matt711 Matt711 requested review from bdice and mroeschke October 9, 2024 01:01
@Matt711 Matt711 changed the title [WIP] Migrate Min Hashing APIs to pylibcudf Migrate Min Hashing APIs to pylibcudf Oct 9, 2024
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion about the device_span. Since it's not a detail API, I think technically it should be exposed in pylibcudf

@vyasr
Copy link
Contributor

vyasr commented Oct 9, 2024

I don't expect pylibcudf users to ever need the equivalent of a device_span. In C++ spans are useful as a way to create views on data owned by another object, but in pylibcudf Columns already have this ability baked in because they have to match Python's referencing semantics. The pylibcudf implementation in this PR demonstrates that since they only take Columns (you didn't bother to create a span overload). With that in mind, I don't think it's important to expose span-based libcudf APIs to pylibcudf if there is a column-based alternative.

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit c8a56a5 into rapidsai:branch-24.12 Oct 11, 2024
121 checks passed
@Matt711 Matt711 mentioned this pull request Nov 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants