Add string.convert.convert_urls APIs to pylibcudf #17003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
github-actions
bot
added
libcudf
| @@ -8,7 +8,7 @@ from pylibcudf.libcudf.column.column_view cimport column_view | |||
| cdef extern from "cudf/strings/convert/convert_urls.hpp" namespace \ | |||
| "cudf::strings" nogil: | |||
| cdef unique_ptr[column] url_encode( | |||
| column_view input_col) except + | |||
| column_view input) except + | |||
There was a problem hiding this comment.
@vyasr should we be marking these APIs all with libcudf_exception_handler as we go even if currently the API has no documented exception cases?
There was a problem hiding this comment.
I think that's probably a good best practice yeah.
There was a problem hiding this comment.
xref #17036 to follow up in the future
brandon-b-miller
approved these changes
Oct 4, 2024
…trings/convert_urls
ttnghia
approved these changes
Oct 8, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #15162
Also I believe the cpp docstrings were incorrect, but could use a second look.
Checklist