Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary std::move's in pylibcudf #16983

Merged
merged 8 commits into from
Oct 16, 2024
Merged

Remove unnecessary std::move's in pylibcudf #16983

merged 8 commits into from
Oct 16, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 2, 2024 •
edited by vyasr
Loading

Description

This PR removes a lot of unnecessary std::move's from pylibcudf. These were necessary with older versions of Cython, but newer versions appear to generate the correct C++ without needing the extra hints.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 2, 2024
@Matt711 Matt711 self-assigned this Oct 2, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue pylibcudf Issues specific to the pylibcudf package labels Oct 2, 2024
@Matt711 Matt711 changed the title [WIP] Remove unnecessary move's in pylibcudf [WIP] Remove unnecessary `mcoccccbrfutcbvcdcldtctuknvcuhrdbrhiendivbdcdene's in pylibcudf Oct 2, 2024
@Matt711 Matt711 changed the title [WIP] Remove unnecessary `mcoccccbrfutcbvcdcldtctuknvcuhrdbrhiendivbdcdene's in pylibcudf [WIP] Remove unnecessary std::move's in pylibcudf Oct 2, 2024
@Matt711 Matt711 removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 3, 2024
@github-actions github-actions bot removed the CMake CMake build issue label Oct 12, 2024
@Matt711 Matt711 changed the title [WIP] Remove unnecessary std::move's in pylibcudf Remove unnecessary std::move's in pylibcudf Oct 12, 2024
@Matt711 Matt711 changed the title Remove unnecessary std::move's in pylibcudf Remove unnecessary std::moves in pylibcudf Oct 12, 2024
@Matt711 Matt711 changed the title Remove unnecessary std::moves in pylibcudf Remove unnecessary std::move's in pylibcudf Oct 12, 2024
@Matt711 Matt711 marked this pull request as ready for review October 12, 2024 02:11
@Matt711 Matt711 requested a review from a team as a code owner October 12, 2024 02:11
@Matt711 Matt711 requested review from mroeschke and isVoid October 12, 2024 02:11
@Matt711 Matt711 added the 3 - Ready for Review Ready for review by team label Oct 12, 2024
@Matt711 Matt711 requested a review from vyasr October 15, 2024 00:13
vyasr
vyasr approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hard to be sure we got them all, but we can always make another PR if we find more.

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 16, 2024

/merge

@rapids-bot rapids-bot bot merged commit 95df62a into rapidsai:branch-24.12 Oct 16, 2024
126 checks passed
@Matt711 Matt711 mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt711 @vyasr