Add APIs to copy data to and from device to cudf::detail::host_vector
#16931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fea-host_vector-to-and-from-device
…fea-host_vector-to-and-from-device
vuule
added
improvement
|
Decided to take a different approach, opened #16945 with a more general API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current utilities for D2H/H2D copying do not cover well the case where data is transferred between an existing
cudf::detail::host_vectorand an existing device memory. To potentially avoid copy engine use, the caller needs to know if thehost_vectorin question actually uses pinned memory. This makes the code very verbose and dependent onhost_vectorimplementation details.This PR adds APIs to copy the content of a
host_vectorto the given device memory location.Checklist