Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all rmm imports to use pylibrmm/librmm #16913

Merged
merged 12 commits into from
Oct 10, 2024
Merged

Update all rmm imports to use pylibrmm/librmm #16913

merged 12 commits into from
Oct 10, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Sep 25, 2024 •
edited
Loading

Description

This PR updates all the RMM imports to use pylibrmm/librmm now that rmm._lib is deprecated . It should be merged after rmm/1676.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added bug Something isn't working 5 - DO NOT MERGE Hold off on merging; see PR for details labels Sep 25, 2024
@Matt711 Matt711 self-assigned this Sep 25, 2024
@Matt711 Matt711 added the non-breaking Non-breaking change label Sep 25, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Sep 25, 2024
@Matt711 Matt711 removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 3, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 6, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 6, 2024

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 6, 2024

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 7, 2024

/ok to test

@Matt711 Matt711 marked this pull request as ready for review October 7, 2024 17:06
@Matt711 Matt711 requested a review from a team as a code owner October 7, 2024 17:06
@Matt711 Matt711 requested review from wence- and charlesbluca and removed request for charlesbluca October 7, 2024 17:06
@Matt711 Matt711 requested review from vyasr and galipremsagar October 7, 2024 17:07
@Matt711 Matt711 changed the title [WIP] Update all rmm imports to use pylibrmm/librmm Update all rmm imports to use pylibrmm/librmm Oct 7, 2024
@Matt711 Matt711 added the 3 - Ready for Review Ready for review by team label Oct 8, 2024
wence-
wence- approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks right to me.

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 9, 2024

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit 31423d0 into rapidsai:branch-24.12 Oct 10, 2024
101 checks passed
@Matt711 Matt711 mentioned this pull request Oct 23, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Oct 23, 2024
@Matt711
Use the full ref name of rmm.DeviceBuffer in the sphinx config file (…
0287972 
…#17150)

This is an improvement PR that uses the full name of `rmm.DeviceBuffer` in the sphinx config file. Its a follow-up to this [comment](#16913 (comment)).

Authors:
  - Matthew Murray (https://github.com/Matt711)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #17150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbluca charlesbluca charlesbluca approved these changes

@wence- wence- wence- approved these changes

@vyasr vyasr Awaiting requested review from vyasr

@galipremsagar galipremsagar Awaiting requested review from galipremsagar

Assignees

@Matt711 Matt711

Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Matt711 @wence- @vyasr @charlesbluca