Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strings.combine APIs to pylibcudf #16790

Merged
merged 15 commits into from
Oct 17, 2024
Merged

Add strings.combine APIs to pylibcudf #16790

merged 15 commits into from
Oct 17, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Sep 10, 2024 •
edited
Loading

Description

Contributes to #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Sep 10, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue and removed pylibcudf Issues specific to the pylibcudf package labels Sep 10, 2024
@mroeschke mroeschke marked this pull request as ready for review September 16, 2024 22:19
@mroeschke mroeschke requested a review from a team as a code owner September 16, 2024 22:19
@mroeschke mroeschke requested review from wence- and bdice September 16, 2024 22:19
@mroeschke mroeschke mentioned this pull request Sep 16, 2024
Closed
@Matt711 Matt711 added the pylibcudf Issues specific to the pylibcudf package label Sep 19, 2024
wence-
wence- requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this API is one where our fused type overloads start to get quite clunky.

I am also concerned about null-preserving usage.

python/cudf/cudf/_lib/strings/combine.pyx Show resolved Hide resolved
python/pylibcudf/pylibcudf/strings/combine.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/strings/combine.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/strings/combine.pyx Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/test_string_combine.py Outdated Show resolved Hide resolved
@Matt711 Matt711 changed the base branch from branch-24.10 to branch-24.12 September 25, 2024 19:11
@mroeschke
Copy link
Contributor Author

Sorry for the delay here. bdb3392 should have address the outstanding reviews

@mroeschke mroeschke requested a review from wence- October 11, 2024 18:38
wence-
wence- approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor docstring suggestions, thanks!

docs/cudf/source/user_guide/api_docs/pylibcudf/strings/index.rst Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/strings/combine.pyx Show resolved Hide resolved
python/pylibcudf/pylibcudf/strings/combine.pyx Outdated Show resolved Hide resolved
@Matt711
Copy link
Contributor

Matt711 commented Oct 17, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3683e46 into rapidsai:branch-24.12 Oct 17, 2024
101 checks passed
@mroeschke mroeschke deleted the pylibcudf/strings/combine branch October 30, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller left review comments

@vyasr vyasr vyasr left review comments

@Matt711 Matt711 Matt711 approved these changes

@wence- wence- wence- approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mroeschke @Matt711 @wence- @vyasr @brandon-b-miller