Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining string.char_types APIs to pylibcudf #16788

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Add remaining string.char_types APIs to pylibcudf #16788

merged 8 commits into from
Oct 1, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Sep 10, 2024
@mroeschke mroeschke requested a review from a team as a code owner September 10, 2024 22:11
@mroeschke mroeschke requested review from wence- and bdice September 10, 2024 22:11
@github-actions github-actions bot added Python Affects Python cuDF API. and removed pylibcudf Issues specific to the pylibcudf package labels Sep 10, 2024
@mroeschke mroeschke mentioned this pull request Sep 10, 2024
Closed
@Matt711 Matt711 added the pylibcudf Issues specific to the pylibcudf package label Sep 19, 2024
wence-
wence- requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits/suggestions. Code looks good but some docstrings are incorrect I think.

python/cudf/cudf/_lib/strings/char_types.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/strings/char_types.pyx Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/strings/char_types.pyx Outdated Show resolved Hide resolved
@Matt711 Matt711 requested a review from a team as a code owner September 25, 2024 19:59
@Matt711 Matt711 requested a review from ttnghia September 25, 2024 19:59
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 25, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 25, 2024
@Matt711
Copy link
Contributor

Matt711 commented Sep 25, 2024

/ok to test

@Matt711 Matt711 changed the base branch from branch-24.10 to branch-24.12 September 25, 2024 20:03
@github-actions github-actions bot added the CMake CMake build issue label Sep 25, 2024
@Matt711 Matt711 force-pushed the pylibcudf/char_types branch from 494f86d to 0059b38 Compare September 25, 2024 20:14
@Matt711 Matt711 requested review from a team as code owners September 25, 2024 20:14
@github-actions github-actions bot added the cudf.polars Issues specific to cudf.polars label Sep 25, 2024
@Matt711
Copy link
Contributor

Matt711 commented Sep 25, 2024

Sorry for the noise. I'll clean up this PR.

@Matt711 Matt711 force-pushed the pylibcudf/char_types branch from 0059b38 to a0e8b1d Compare September 25, 2024 21:19
@github-actions github-actions bot removed CMake CMake build issue cudf.polars Issues specific to cudf.polars labels Sep 25, 2024
wence-
wence- approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Matt711 Matt711 requested a review from ttnghia October 1, 2024 13:10
@Matt711
Copy link
Contributor

Matt711 commented Oct 1, 2024

/merge

@rapids-bot rapids-bot bot merged commit e46437c into rapidsai:branch-24.12 Oct 1, 2024
102 checks passed
@mroeschke mroeschke deleted the pylibcudf/char_types branch October 1, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@ttnghia ttnghia ttnghia approved these changes

@wence- wence- wence- approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @Matt711 @wence- @ttnghia