-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update patches for CCCL 2.6 #16668
Update patches for CCCL 2.6 #16668
Conversation
… due to code changes in thrust. This adopts those patches to apply with CCCL 2.6. Should only be merged when updating the CCCL version
+ status = call arguments; \ | ||
+ } \ | ||
+ else \ | ||
+ { \ | ||
+ throw std::runtime_error("THRUST_INDEX_TYPE_DISPATCH 64-bit count is unsupported in libcudf"); \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our formatter did some crazy things here, so that the patches are less localized. Shout if you need them to be minimal
Better yet would be to just nuke these patches. I believe we can do that once these two CCCL issues are done:
|
It looks like both of the above are merged now (NVIDIA/cccl#2154 just merged yesterday) so in principle we should be able to drop these patches if we upgrade straight to CCCL>=2.6.2. |
@jrhemstad @vyasr We have three patches, and I see two fixes. I see how the CCCL offset-dispatch changes will fix I don't see a solution for the It'd be nice to update CCCL and drop all patches at once, but it'd be okay to get rid of two if we aren't able to solve the third one in the near term. |
That's a good question. I didn't investigate and was just responding to the comments. If we have to keep one patch around that's not the end of the world, although if that's the case given that the other bits were resolved upstream we should open a CCCL issue requesting the change to sort as well. |
We have moved to CCCL 2.7 so perhaps this can be closed? |
Yes, I included the relevant parts in #17233. Thanks for the help! Closing. |
This adopts the patches to thrust to apply with CCCL 2.6.
Should only be merged when updating the CCCL version, but I am opening them now to not forget it and then accidentally drop them