Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the missing num_aggregations axis for groupby_max_cardinality #16630

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add the missing num_aggregations axis for groupby_max_cardinality #16630

merged 1 commit into from
Aug 23, 2024

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Aug 21, 2024 •
edited
Loading

Description

This PR fixes a minor bug where the num_aggregations axis was missed when working on #16154.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 21, 2024
@PointKernel PointKernel requested a review from a team as a code owner August 21, 2024 19:09
@PointKernel PointKernel self-assigned this Aug 21, 2024
@PointKernel PointKernel changed the title Add the missing axis for groupby_max_cardinality Add the missing num_aggregations axis for groupby_max_cardinality Aug 21, 2024
@PointKernel
Copy link
Member Author

@bdice @davidwendt Thank you to both of you.

@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit a7ca3af into rapidsai:branch-24.10 Aug 23, 2024
86 checks passed
@PointKernel PointKernel deleted the fix-groupby-cardinality-bench branch August 23, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice bdice approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@pmattione-nvidia pmattione-nvidia Awaiting requested review from pmattione-nvidia pmattione-nvidia is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@PointKernel PointKernel

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PointKernel @bdice @davidwendt