Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove thrust::optional from expression evaluator #16604

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Remove thrust::optional from expression evaluator #16604

merged 1 commit into from
Aug 20, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 19, 2024

Description

This PR follows up on a request from @davidwendt in #15091 (comment).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 19, 2024
@bdice bdice mentioned this pull request Aug 19, 2024
Merged
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 19, 2024
@bdice bdice self-assigned this Aug 19, 2024
@bdice bdice marked this pull request as ready for review August 19, 2024 21:33
@bdice bdice requested a review from a team as a code owner August 19, 2024 21:33
@bdice
Copy link
Contributor Author

bdice commented Aug 20, 2024

/merge

@rapids-bot rapids-bot bot merged commit 555734d into rapidsai:branch-24.10 Aug 20, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@vyasr vyasr vyasr approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@JayjeetAtGithub JayjeetAtGithub Awaiting requested review from JayjeetAtGithub JayjeetAtGithub is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@bdice bdice

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @vyasr @davidwendt