Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NumPy <2 pin #16594

Closed
wants to merge 2 commits into from
Closed

Conversation

seberg
Copy link
Contributor

@seberg seberg commented Aug 19, 2024

This PR removes the NumPy<2 pin which is expected to work for
RAPIDS projects once CuPy 13.3.0 is released (CuPy 13.2.0 had
some issues preventing the use with NumPy 2).

@seberg seberg added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 19, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 19, 2024
@jakirkham
Copy link
Member

jakirkham commented Aug 21, 2024

Thanks Sebastian! 🙏

Just a reminder to ourselves and a note to others, we will want to merge PR ( #16300 ) first and then rebase (or regenerate) this PR on top of that one

Sebastian made the observation that the portion of NumPy's C API that cuDF uses via Arrow is probably unaffected by NumPy 2 changes. That said, it is coming from Arrow (and am not sure what else is going on there). So it is probably safer to do the usual thing and rebuild with NumPy 2 (as that PR does)

@jakirkham jakirkham mentioned this pull request Aug 21, 2024
3 tasks
@seberg
Copy link
Contributor Author

seberg commented Aug 22, 2024

Closing this one, gh-16300 now includes dropping the runtime pin, we can work there (or reopen if needed).

@seberg seberg closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants