-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Test against old versions of key dependencies #16570
Merged
Merged
Changes from 16 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
749752d
CI: Test against old versions of key dependencies
seberg c4f8547
Use constraints for pip (incidentally fixing cupy install issues)
seberg 3a416aa
Remove fsspec from pin for now (could constraint to 2023.5.0)
seberg b22d111
Consolidate pip installs, fix constraints and use for cudf-pandas tests
seberg 224f944
TST: xfail test that clearly requires newer pandas versions
seberg b926cd3
TST: Reinstate (most) test version checks removed in 15100
seberg 1d6c037
Update ci/test_python_common.sh
seberg e97d6fe
Merge branch 'branch-24.10' into test-oldest
seberg d84b0e3
Clean up pylibcudf merge conflict
seberg b5c17a2
Merge branch 'branch-24.10' into test-oldest
seberg c267b1e
Merge branch 'branch-24.10' into test-oldest
seberg 062f601
Use oldest deps also in cudf_pandas_scripts/pandas-tests/run.sh
seberg 4fff8b5
TST: More (heavy handed) test fixups to ignore old pandas failures
seberg 3420a8c
More heavy handed test fixes
seberg caccd02
TST: Apply cudf_pandas_test fixes from gh-16595
seberg 7f308df
Merge branch 'branch-24.10' into test-oldest
mroeschke 5a165e2
Skip 2 more unit tests for older pandas versions
mroeschke f740c67
Merge remote-tracking branch 'upstream/branch-24.10' into test-oldest
mroeschke 273e18d
Check for min numba
mroeschke b8fcbe7
Merge remote-tracking branch 'upstream/branch-24.10' into test-oldest
mroeschke 3a709a0
Make pyarrow pin 14 instead of 16
mroeschke 5c794ae
Update ci/test_wheel_cudf.sh
mroeschke c7452fb
Merge remote-tracking branch 'upstream/branch-24.10' into test-oldest
mroeschke d09c47f
Change some xfails to skip
mroeschke f9eb3ab
Merge branch 'test-oldest' of https://github.com/seberg/cudf into tes…
mroeschke 769f37b
Merge remote-tracking branch 'upstream/branch-24.10' into test-oldest
mroeschke d701297
skip test_p2p_shuffle for min pyarrow version
mroeschke a994001
Merge branch 'branch-24.10' into test-oldest
galipremsagar 309dd5b
Merge branch 'branch-24.10' into test-oldest
mroeschke 54b646e
Merge branch 'branch-24.10' into test-oldest
mroeschke 3928ba1
Merge remote-tracking branch 'upstream/branch-24.10' into test-oldest
mroeschke e34a02c
Remove oldest dependency version checking from pandas unit test script
mroeschke d157f1e
Merge branch 'test-oldest' of https://github.com/seberg/cudf into tes…
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we think this is going to be a common pattern that's worth extracting into a gha-tool
generate-oldest-constraints $file_key
or similar? @jameslamb WDYT? It occurs many times in this PR and I assume we'll do something similar in other repos.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think that's worth doing!
The only part that will vary from repo-to-repo is
--file-key
, everything else here is mechanical and a great candidate for agha-tools
script. I could put one up in a day or two, unless you or @seberg want to do it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would suggest one of the two of you pick this up. Sebastian is out for a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could tackle this that would be great @jameslamb. No rush. @mroeschke if you get everything else here finalized and have it ready to merge, I'm fine merging this PR with this code in and refactoring in a follow-up when James has the gha-tool ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put up a proposal in rapidsai/gha-tools#114