Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the java code to properly deal with lists being returned as strings #16536

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Aug 12, 2024

Description

Recently some JSON parsing was updated so lists could be returned as strings. This updates the java code so that when cleaning up the results to match the desired schema that it can handle corner cases associated with lists and structs properly.

Tests are covered in the Spark plugin, but I am happy to add some here if we really want to validate that part of this.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@revans2 revans2 added bug Something isn't working 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change cuDF (Java) labels Aug 12, 2024
@revans2 revans2 self-assigned this Aug 12, 2024
@revans2 revans2 requested a review from a team as a code owner August 12, 2024 19:54
@revans2
Copy link
Contributor Author

revans2 commented Aug 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit e5f8dd3 into rapidsai:branch-24.10 Aug 12, 2024
80 checks passed
@revans2 revans2 deleted the update_java_json_lists branch August 12, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants