Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update json normalization to take device_buffer #16520

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Update json normalization to take device_buffer #16520

merged 4 commits into from
Aug 9, 2024

Conversation

karthikeyann
Copy link
Contributor

Description

This change updates json normalization calls (quote and whitespace normalization) to take owning buffer of device_buffer as input rather than device_uvector. It makes it easy to hand over a string_column's char buffer to normalization calls.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team Needs Triage Need team to review and classify libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Needs build-infra Requires input from the build infrastructure team labels Aug 9, 2024
@karthikeyann karthikeyann requested a review from shrshi August 9, 2024 13:59
@karthikeyann karthikeyann self-assigned this Aug 9, 2024
@karthikeyann karthikeyann requested a review from a team as a code owner August 9, 2024 13:59
@karthikeyann karthikeyann requested a review from davidwendt August 9, 2024 13:59
@karthikeyann karthikeyann changed the title update json normalization to take device_buffer Update json normalization to take device_buffer Aug 9, 2024
@karthikeyann karthikeyann requested a review from davidwendt August 9, 2024 15:35
davidwendt
davidwendt approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karthikeyann
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4446cf0 into rapidsai:branch-24.10 Aug 9, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@shrshi shrshi shrshi approved these changes

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Needs build-infra Requires input from the build infrastructure team Needs Triage Need team to review and classify non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikeyann @shrshi @davidwendt