Adapt to IR changes in polars 1.4 #16494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lawrence Mitchell <[email protected]>
lithomas1
added
improvement
github-actions
bot
added
Python
lithomas1
requested review from
wence- and
mroeschke
and removed request for
a team
| @@ -87,7 +87,7 @@ def _( | |||
| if predicate is not None | |||
| else None | |||
| ) | |||
| else: | |||
| else: # pragma: no cover; CI tests 1.4 | |||
There was a problem hiding this comment.
this is fine for now but if the range of polars versions supports becomes wide we might consider having a couple different coverage rc files that specify which lines to ignore and conditionally decide which one to pass based on the polars version
There was a problem hiding this comment.
Good point.
We can cover the oldest and newest polars via CI testing, but not sure if it's worth to expand the CI matrix to cover versions in the middle as well.
brandon-b-miller
approved these changes
Aug 5, 2024
lithomas1
merged commit 7d0c7ad
into
rapidsai:feature/cudf-polars
80 of 81 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapts to IR changes in polars 1.4 and handles nrows/skiprows a little more correctly.
Checklist