Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable list to be forced as string in JSON reader. #16472

Merged
merged 3 commits into from
Aug 9, 2024
Merged

enable list to be forced as string in JSON reader. #16472

merged 3 commits into from
Aug 9, 2024

Conversation

karthikeyann
Copy link
Contributor

@karthikeyann karthikeyann commented Aug 2, 2024 •
edited
Loading

Description

closes #15278

This PR allows list type also forced as string when mixed type as string is enabled and a user given schema specifies a column as string, in JSON reader.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue breaking Breaking change labels Aug 2, 2024
@karthikeyann karthikeyann requested a review from a team as a code owner August 2, 2024 01:28
@karthikeyann karthikeyann requested review from ttnghia and zpuller August 2, 2024 01:28
@karthikeyann karthikeyann added the improvement Improvement / enhancement to an existing function label Aug 2, 2024
@karthikeyann karthikeyann changed the title enable list to be forced as string enable list to be forced as string in JSON reader. Aug 2, 2024
@karthikeyann karthikeyann added feature request New feature or request and removed improvement Improvement / enhancement to an existing function labels Aug 2, 2024
@shrshi shrshi self-requested a review August 2, 2024 19:20
@karthikeyann karthikeyann requested a review from revans2 August 5, 2024 20:01
@GregoryKimball
Copy link
Contributor

@revans2 is it possible to profile the tree algorithms against get_json_object_multiple_paths using this branch?

@ttnghia
Copy link
Contributor

ttnghia commented Aug 6, 2024

@revans2 is it possible to profile the tree algorithms against get_json_object_multiple_paths using this branch?

Sorry we don't use any of this code in get_json_object or get_json_object_multiple_paths thus they are not comparable.

@GregoryKimball
Copy link
Contributor

@karthikeyann is this ready to merge?

@karthikeyann
Copy link
Contributor Author

yes. it's ready to merge.

@karthikeyann
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2c8de62 into rapidsai:branch-24.10 Aug 9, 2024
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@shrshi shrshi shrshi approved these changes

@zpuller zpuller Awaiting requested review from zpuller zpuller is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@revans2 revans2 Awaiting requested review from revans2

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team breaking Breaking change cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Support casting of LIST type to STRING in JSON
4 participants
@karthikeyann @GregoryKimball @ttnghia @shrshi