Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Column.can_cast_safely instead of some ad-hoc dtype functions in .where #16303

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

mroeschke
Copy link
Contributor

Description

There were a couple of dedicated functions in python/cudf/cudf/utils/dtypes.py specific to .where that could be subsumed by Column.can_cast_safely.

The minor downside is that we need to cast where's argument to a Column first, but IMO it's probably OK given the deduplication

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 18, 2024
@mroeschke mroeschke requested a review from a team as a code owner July 18, 2024 02:51
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4acca4d into rapidsai:branch-24.08 Jul 18, 2024
79 checks passed
@mroeschke mroeschke deleted the ref/dtype/casting branch July 18, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants