Use Column.can_cast_safely instead of some ad-hoc dtype functions in .where #16303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were a couple of dedicated functions in
python/cudf/cudf/utils/dtypes.py
specific to.where
that could be subsumed byColumn.can_cast_safely
.The minor downside is that we need to cast where's argument to a Column first, but IMO it's probably OK given the deduplication
Checklist