Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix split_record for all empty strings column #16291

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix split_record for all empty strings column #16291

merged 1 commit into from
Jul 18, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes cudf::strings::split_record handling of an all empty strings column. This caused a kernel launch with no threads eventually reporting a CUDA error. A new gtest was added to check this condition and includes tests for rsplit_record as well.

Closes #16284

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) non-breaking Non-breaking change labels Jul 16, 2024
@davidwendt davidwendt self-assigned this Jul 16, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 16, 2024
@davidwendt davidwendt marked this pull request as ready for review July 16, 2024 20:50
@davidwendt davidwendt requested a review from a team as a code owner July 16, 2024 20:50
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c4471c4 into rapidsai:branch-24.08 Jul 18, 2024
79 checks passed
@davidwendt davidwendt deleted the bug-empty-split-record branch July 18, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@ttnghia ttnghia ttnghia approved these changes

@zpuller zpuller Awaiting requested review from zpuller zpuller is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] strings::split_record throws exception on input having one empty row
3 participants
@davidwendt @ttnghia @PointKernel