Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cudf::detail::grid_1d to use thread_index_type #16276

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates the cudf::detail::grid_1d to use thread_index_type instead of int and size_type for the number threads and blocks.
This has become important for launching kernels with more threads than max size_type total bytes for warp-per-row and thread-per-byte algorithms.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 12, 2024
@davidwendt davidwendt self-assigned this Jul 12, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 15, 2024
@davidwendt davidwendt marked this pull request as ready for review July 15, 2024 13:58
@davidwendt davidwendt requested a review from a team as a code owner July 15, 2024 13:58
@davidwendt davidwendt requested review from bdice and nvdbaranec July 15, 2024 13:58
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 093bcc9 into rapidsai:branch-24.08 Jul 17, 2024
79 checks passed
@davidwendt davidwendt deleted the grid1d-thread-idx-type branch July 17, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants