Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xml from sort_ninja_log.py utility #16274

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Remove xml from sort_ninja_log.py utility #16274

merged 1 commit into from
Jul 17, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Removes xml support from the sort_ninja_log.py utility. The xml support was experimental for possible use with Jenkins reporting that never materialized.
This script is used in build.sh generally when running local builds.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 12, 2024
@davidwendt davidwendt self-assigned this Jul 12, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 12, 2024
@davidwendt davidwendt marked this pull request as ready for review July 15, 2024 13:58
@davidwendt davidwendt requested a review from a team as a code owner July 15, 2024 13:58
srinivasyadav18
srinivasyadav18 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@srinivasyadav18 srinivasyadav18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2f8d514 into rapidsai:branch-24.08 Jul 17, 2024
84 checks passed
@davidwendt davidwendt deleted the bmr-remove-xml branch July 17, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinivasyadav18 srinivasyadav18 srinivasyadav18 approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @srinivasyadav18