Replace is_bool_type with checking .dtype.kind #16255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
mroeschke
commented
Jul 11, 2024
| @@ -840,10 +840,6 @@ def _get_row_major( | |||
| | tuple[Any, ...] | |||
| | list[tuple[Any, ...]], | |||
| ) -> DataFrameOrSeries: | |||
| if pd.api.types.is_bool_dtype( | |||
There was a problem hiding this comment.
While running the test suite locally, I didn't see this branch ever getting hit
vyasr
approved these changes
Jul 15, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It appears this was called when we already had a dtype object so can instead just simply check the .kind attribute
Checklist