Short circuit some Column methods #16246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
vyasr
approved these changes
Jul 15, 2024
| except AttributeError: | ||
| # `self.memory_usage` was never called before, So ignore. | ||
| pass | ||
| attrs = ("memory_usage", "is_monotonic_increasing", "is_monotonic_decreasing") |
There was a problem hiding this comment.
Are there any places where we need to insert a _clear_cache call that didn't have one before now that these properties are also cached? I did a quick search and didn't find any, but wanted to confirm that you checked too.
There was a problem hiding this comment.
I just looked and it doesn't looks like there's anywhere we truly modify a Column inplace where these attributes might change (I suspected __setitem__ but it appears it's "inplace" where the base data is swapped)
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some short circuiting, possibly cached checks (e.g. all values unique, no-NAs, monotonicity), to
dropna,isnull,notnull,argsort,uniqueandsort_valuesallowing these ops to just copy / return a "simplified" resultChecklist