Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nvcomp adapter compatible with new version macros #16245

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Make nvcomp adapter compatible with new version macros #16245

merged 6 commits into from
Jul 15, 2024

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Jul 10, 2024

Description

New nvcomp version changed the names of the version macros. This PR adds "aliasing" to the old names so rest of the code is not affected.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule self-assigned this Jul 10, 2024
@vuule vuule added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 10, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 10, 2024
@vuule vuule added the cuIO cuIO issue label Jul 10, 2024
@vuule vuule marked this pull request as ready for review July 10, 2024 22:24
@vuule vuule requested a review from a team as a code owner July 10, 2024 22:24
@vuule vuule requested review from ttnghia and JayjeetAtGithub July 10, 2024 22:24
@vuule
Copy link
Contributor Author

vuule commented Jul 10, 2024

CC @GregoryKimball for viz

mythrocks
mythrocks approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

New nvcomp version changed the names of the version macros.

Why would they do such a thing? :|

@vuule
Copy link
Contributor Author

vuule commented Jul 15, 2024

/merge

@rapids-bot rapids-bot bot merged commit ceb73d9 into rapidsai:branch-24.08 Jul 15, 2024
79 checks passed
@vuule vuule deleted the fea-nvcomp-4-compat branch July 15, 2024 19:45
@vuule
Copy link
Contributor Author

vuule commented Jul 15, 2024

LGTM.

New nvcomp version changed the names of the version macros.

Why would they do such a thing? :|

I think the goal was to align with similar libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@mythrocks mythrocks mythrocks approved these changes

@ttnghia ttnghia Awaiting requested review from ttnghia ttnghia is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@JayjeetAtGithub JayjeetAtGithub Awaiting requested review from JayjeetAtGithub JayjeetAtGithub is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @mythrocks @mhaseeb123