Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Column.strftime/strptime instead of overloading as_string/datetime/timedelta_column #16243

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Jul 10, 2024

Description

Column.as_string/datetime/timedelta_column had a format argument that was not used for columns that weren't these types or didn't require conversion to these types.

This PR introduces a strftime and strptime on the column that will handle this format argument.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 10, 2024
@mroeschke mroeschke requested a review from a team as a code owner July 10, 2024 20:37
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 53de73d into rapidsai:branch-24.08 Jul 11, 2024
84 checks passed
@mroeschke mroeschke deleted the ref/dttd/conversion branch July 11, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants