Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose sorted groupby parameters to pylibcudf #16240

Merged
merged 14 commits into from
Jul 12, 2024
Merged

Expose sorted groupby parameters to pylibcudf #16240

merged 14 commits into from
Jul 12, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jul 10, 2024

Description

And plumb through to cudf-polars.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Jul 10, 2024
@wence- wence- force-pushed the wence/fea/pylibcudf-sort-groupby branch from 78cec2e to 9bb267f Compare July 11, 2024 12:25
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 11, 2024
@wence- wence- marked this pull request as ready for review July 11, 2024 12:27
@wence- wence- requested a review from a team as a code owner July 11, 2024 12:27
brandon-b-miller
brandon-b-miller reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

various comments/nits/questions, I need to go over the last two files still.

@brandon-b-miller
Copy link
Contributor

Looks like a minor merge conflict, otherwise LGTM

@wence-
Copy link
Contributor Author

wence- commented Jul 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1737e70 into rapidsai:branch-24.08 Jul 12, 2024
80 checks passed
@wence- wence- deleted the wence/fea/pylibcudf-sort-groupby branch October 24, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wence- @brandon-b-miller