Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom name setter and getter for proxy objects in cudf.pandas #16234

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Add custom name setter and getter for proxy objects in cudf.pandas #16234

merged 4 commits into from
Jul 11, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Jul 9, 2024 •
edited
Loading

Description

Closes #14524

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added bug Something isn't working non-breaking Non-breaking change cudf.pandas Issues specific to cudf.pandas labels Jul 9, 2024
@Matt711 Matt711 self-assigned this Jul 9, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 9, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 10, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Matt711 Matt711 changed the title Add custom getter for index.name Add custom name setter and getter for proxy objects in cudf.pandas Jul 10, 2024
@Matt711 Matt711 marked this pull request as ready for review July 10, 2024 21:36
@Matt711 Matt711 requested a review from a team as a code owner July 10, 2024 21:36
@Matt711 Matt711 requested review from bdice and isVoid July 10, 2024 21:36
@Matt711
Copy link
Contributor Author

Matt711 commented Jul 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit 2b2058d into rapidsai:branch-24.08 Jul 11, 2024
83 checks passed
@galipremsagar galipremsagar mentioned this pull request Jul 12, 2024
Closed
@Matt711 Matt711 mentioned this pull request Jul 12, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Jul 16, 2024
@Matt711
[BUG] Make name attr of Index fast slow attrs (#16270)
6219110 
Debugging the spike in failures from #16234

Authors:
  - Matthew Murray (https://github.com/Matt711)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #16270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] df.index.name = "indexer" does not work as expected under cudf.pandas
2 participants
@Matt711 @bdice