-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back when casting a timestamp to numeric in cudf-polars #16232
Merged
rapids-bot
merged 8 commits into
rapidsai:branch-24.08
from
brandon-b-miller:fix-cudf-polars-timestamp-casting
Jul 23, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f54dd43
raise when casting from timestamp to numeric
brandon-b-miller 2f6a6ff
Merge branch 'branch-24.08' into fix-cudf-polars-timestamp-casting
brandon-b-miller 1c6db1b
use libcudf traits
brandon-b-miller 35c0e70
cleanup
brandon-b-miller 1db84d6
Merge branch 'branch-24.08' into fix-cudf-polars-timestamp-casting
brandon-b-miller dc0ebbb
use is_supported_cast
brandon-b-miller a140cd0
Update python/cudf_polars/cudf_polars/dsl/expr.py
brandon-b-miller a2858e6
basic tests
brandon-b-miller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. | ||
# SPDX-License-Identifier: Apache-2.0 | ||
from __future__ import annotations | ||
|
||
import pytest | ||
|
||
import polars as pl | ||
|
||
from cudf_polars.testing.asserts import ( | ||
assert_gpu_result_equal, | ||
assert_ir_translation_raises, | ||
) | ||
|
||
_supported_dtypes = [(pl.Int8(), pl.Int64())] | ||
|
||
_unsupported_dtypes = [ | ||
(pl.String(), pl.Int64()), | ||
] | ||
|
||
|
||
@pytest.fixture | ||
def dtypes(request): | ||
return request.param | ||
|
||
|
||
@pytest.fixture | ||
def tests(dtypes): | ||
fromtype, totype = dtypes | ||
if fromtype == pl.String(): | ||
data = ["a", "b", "c"] | ||
else: | ||
data = [1, 2, 3] | ||
return pl.DataFrame( | ||
{ | ||
"a": pl.Series(data, dtype=fromtype), | ||
} | ||
).lazy(), totype | ||
|
||
|
||
@pytest.mark.parametrize("dtypes", _supported_dtypes, indirect=True) | ||
def test_cast_supported(tests): | ||
df, totype = tests | ||
q = df.select(pl.col("a").cast(totype)) | ||
assert_gpu_result_equal(q) | ||
|
||
|
||
@pytest.mark.parametrize("dtypes", _unsupported_dtypes, indirect=True) | ||
def test_cast_unsupported(tests): | ||
df, totype = tests | ||
assert_ir_translation_raises( | ||
df.select(pl.col("a").cast(totype)), NotImplementedError | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test this branch please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a2858e6 should cover things