Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back when casting a timestamp to numeric in cudf-polars #16232

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Fall back when casting a timestamp to numeric in cudf-polars #16232

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f54dd43
raise when casting from timestamp to numeric
brandon-b-miller Jul 9, 2024
2f6a6ff
Merge branch 'branch-24.08' into fix-cudf-polars-timestamp-casting
brandon-b-miller Jul 9, 2024
1c6db1b
use libcudf traits
brandon-b-miller Jul 9, 2024
35c0e70
cleanup
brandon-b-miller Jul 9, 2024
1db84d6
Merge branch 'branch-24.08' into fix-cudf-polars-timestamp-casting
brandon-b-miller Jul 22, 2024
dc0ebbb
use is_supported_cast
brandon-b-miller Jul 22, 2024
a140cd0
Update python/cudf_polars/cudf_polars/dsl/expr.py
brandon-b-miller Jul 22, 2024
a2858e6
basic tests
brandon-b-miller Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/cudf_polars/cudf_polars/dsl/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,6 +1160,10 @@ class Cast(Expr):
def __init__(self, dtype: plc.DataType, value: Expr) -> None:
super().__init__(dtype)
self.children = (value,)
if not plc.unary.is_supported_cast(self.dtype, value.dtype):
raise NotImplementedError(
f"Can't cast {self.dtype.id().name} to {value.dtype.id().name}"
)
Comment on lines +1164 to +1166
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test this branch please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a2858e6 should cover things


def do_evaluate(
self,
Expand Down
Loading