Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mr param from write_csv and write_json #16231

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Remove mr param from write_csv and write_json #16231

merged 7 commits into from
Jul 10, 2024

Conversation

JayjeetAtGithub
Copy link
Contributor

@JayjeetAtGithub JayjeetAtGithub commented Jul 9, 2024 •
edited
Loading

Description

Fixes #16200

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 9, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 9, 2024
@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review July 9, 2024 02:54
@JayjeetAtGithub JayjeetAtGithub requested a review from a team as a code owner July 9, 2024 02:54
@JayjeetAtGithub
Copy link
Contributor Author

/ok to test

@JayjeetAtGithub JayjeetAtGithub changed the title Remore mr param from write_csv and write_json Remove mr param from write_csv and write_json Jul 9, 2024
@srinivasyadav18 srinivasyadav18 added the improvement Improvement / enhancement to an existing function label Jul 9, 2024
@JayjeetAtGithub
Copy link
Contributor Author

I am not sure if we want to remove the mr parameter from the detail API. I removed it for now, but can add it back in no time.

vuule
vuule reviewed Jul 9, 2024
View reviewed changes
cpp/src/io/json/write_json.cu Outdated Show resolved Hide resolved
bdice
bdice reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a deprecation cycle or breaking label?

@JayjeetAtGithub JayjeetAtGithub added the breaking Breaking change label Jul 9, 2024
@JayjeetAtGithub
Copy link
Contributor Author

Does this need a deprecation cycle or breaking label?

@bdice Any pointers on how to go about this would be really helpfull

@vuule
Copy link
Contributor

vuule commented Jul 9, 2024

IMO we can make a breaking change. I would be very surprised if anyone calling these APIs passes the mr parameter.

@bdice
Copy link
Contributor

bdice commented Jul 9, 2024

Does this need a deprecation cycle or breaking label?

@bdice Any pointers on how to go about this would be really helpfull

See the developer guide here: https://github.com/rapidsai/cudf/blob/branch-24.08/cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md#deprecating-and-removing-code

However if @vuule is okay with making a breaking change, we do not need to go through a deprecation cycle.

@vuule
Copy link
Contributor

vuule commented Jul 9, 2024

/ok to test

@JayjeetAtGithub
Copy link
Contributor Author

/ok to test

@JayjeetAtGithub
Copy link
Contributor Author

/ok to test

@JayjeetAtGithub
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 64e3e8d into rapidsai:branch-24.08 Jul 10, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@bdice bdice bdice approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@srinivasyadav18 srinivasyadav18 Awaiting requested review from srinivasyadav18 srinivasyadav18 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove memory resource parameter from cudf::io::write_csv and cudf::io::write_json() APIs
4 participants
@JayjeetAtGithub @vuule @bdice @srinivasyadav18