-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up state variables in MultiIndex #16203
Merged
rapids-bot
merged 15 commits into
rapidsai:branch-24.08
from
mroeschke:ref/mi/from_frame
Jul 12, 2024
Merged
Clean up state variables in MultiIndex #16203
rapids-bot
merged 15 commits into
rapidsai:branch-24.08
from
mroeschke:ref/mi/from_frame
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
cuDF (Python)
labels
Jul 5, 2024
…into ref/mi/from_frame
mroeschke
changed the title
Move MultiIndex.from_frame implementation to MultiIndex._from_data
Clean up state variables in MultiIndex
Jul 9, 2024
Hm, I haven't really used MultiIndexes before, so probably not the best person to review here. @galipremsagar Do you want to take a look at this one? |
galipremsagar
approved these changes
Jul 12, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MultiIndex sets it's own state variables outside of
__init__
and allows some uninitialized private variables that may be called in other methods. This PR now ensures these state variables are always initialized in__init__
,_from_data
and_simple_new
Checklist