Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast count aggs to correct dtype in translation #16192

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Cast count aggs to correct dtype in translation #16192

merged 1 commit into from
Jul 4, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jul 3, 2024

Description

Polars default dtypes for some aggregations, particularly count, don't match ours, so insert casts.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 3, 2024
@wence- wence- requested a review from a team as a code owner July 3, 2024 17:36
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jul 3, 2024
@wence-
Copy link
Contributor Author

wence- commented Jul 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit aa4033c into rapidsai:branch-24.08 Jul 4, 2024
78 checks passed
@wence- wence- deleted the wence/fea/polars-count-dtype branch July 4, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wence- @mroeschke