-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support at/iat indexers in cudf.pandas #16177
Conversation
|
||
|
||
@pytest.mark.parametrize("indexer", ["at", "iat"]) | ||
def test_at_iat(indexer): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this cover the case of a new column that doesn't exist? I'd like to see a test that more clearly resembles the patterns in the minimal repro of #16112.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, added a unit test in a43454c to mirror the issue. (It appears that iat.__setitem__
in pandas doesn't support the type of behavior demonstrated in the issue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, thanks for encouraging a unit test with the issue. Even though the test passed locally the CI didn't agree.
Left some investigation notes in #16112 (comment) that I may come back to later
@mroeschke There's one failing test:
Once that's fixed up I can approve. |
Thanks @bdice all green here |
/merge |
Description
closes #16112
Checklist