Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement translation for some unary functions and a single datetime extraction #16173

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Implement translation for some unary functions and a single datetime extraction #16173

merged 4 commits into from
Jul 5, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jul 2, 2024 •
edited
Loading

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested a review from a team as a code owner July 2, 2024 16:09
@wence- wence- requested review from vyasr and mroeschke July 2, 2024 16:09
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jul 2, 2024
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 3, 2024
lithomas1
lithomas1 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM now.

@wence-
Copy link
Contributor Author

wence- commented Jul 5, 2024

/merge

@rapids-bot rapids-bot bot merged commit c978181 into rapidsai:branch-24.08 Jul 5, 2024
78 checks passed
@wence- wence- deleted the wence/fea/polars-unique-datetime branch July 5, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lithomas1 lithomas1 lithomas1 approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Support unique expression (polars)
2 participants
@wence- @lithomas1