-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment variable to log cudf.pandas fallback calls #16161
Merged
rapids-bot
merged 14 commits into
rapidsai:branch-24.10
from
mroeschke:feat/log_fallback
Jul 31, 2024
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b4795c9
Add environment variable to log fallback calls
mroeschke a3e9c59
Use structured logging
mroeschke 9f3953e
Merge remote-tracking branch 'upstream/branch-24.08' into feat/log_fa…
mroeschke 23a4d26
Merge remote-tracking branch 'upstream/branch-24.08' into feat/log_fa…
mroeschke 6ca5ca0
ensure kwargs are serializeable
mroeschke 2a4ee9a
Merge remote-tracking branch 'upstream/branch-24.08' into feat/log_fa…
mroeschke 9542ec2
dont need the pytest configs afterall
mroeschke aa0d16a
Merge remote-tracking branch 'upstream/branch-24.08' into feat/log_fa…
mroeschke 9a906c2
Merge remote-tracking branch 'upstream/branch-24.08' into feat/log_fa…
mroeschke fb6390a
Merge remote-tracking branch 'upstream/branch-24.08' into feat/log_fa…
mroeschke 18426b1
Merge remote-tracking branch 'upstream/branch-24.08' into feat/log_fa…
mroeschke 53b737c
Address review comments
mroeschke 5689cef
Merge branch 'branch-24.08' into feat/log_fallback
galipremsagar 79324f6
Merge branch 'branch-24.10' into feat/log_fallback
Matt711 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# SPDX-FileCopyrightText: Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. | ||
# All rights reserved. | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
from __future__ import annotations | ||
|
||
import json | ||
import logging | ||
|
||
# https://docs.python.org/3/howto/logging-cookbook.html#implementing-structured-logging | ||
|
||
|
||
class StructuredMessage: | ||
def __init__(self, debug_type: str, /, **kwargs): | ||
self.debug_type = debug_type | ||
self.kwargs = kwargs | ||
|
||
def __str__(self): | ||
log = {"debug_type": self.debug_type} | ||
return json.dumps({**log, **self.kwargs}) | ||
|
||
|
||
logging.basicConfig( | ||
filename="cudf_pandas_unit_tests_debug.log", level=logging.INFO | ||
) | ||
logger = logging.getLogger() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. A copy-paste oversight