Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interpolate returns new column if no values are interpolated #16158

Merged
merged 4 commits into from
Jul 9, 2024
Merged

interpolate returns new column if no values are interpolated #16158

merged 4 commits into from
Jul 9, 2024

Conversation

mroeschke
Copy link
Contributor

Description

While cleaning up the interpolate implementation, I noticed that a interpolation no-op did not return a new column.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Jul 2, 2024
@mroeschke mroeschke requested a review from a team as a code owner July 2, 2024 01:03
@mroeschke mroeschke requested review from galipremsagar and isVoid July 2, 2024 01:03
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 58b7dc9 into rapidsai:branch-24.08 Jul 9, 2024
79 checks passed
@mroeschke mroeschke deleted the cln/interpolate branch July 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @galipremsagar