Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds write-coalescing code path optimization to FST #16143

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Adds write-coalescing code path optimization to FST #16143

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2f1bc13
adds write-coalescing capabilities to fst
elstehle May 13, 2024
a3863c5
tune fst
elstehle May 13, 2024
5967d7b
short-circuit on discard iterators
elstehle May 13, 2024
88a1db5
Merge branch 'branch-24.08' into enh/write-coalescing-fst
elstehle Jul 1, 2024
bbf56f3
fixes style
elstehle Jul 1, 2024
a281c21
fixes copyright
elstehle Jul 1, 2024
071d520
fixes style and makes smem threshold a tuning policy parameter
elstehle Jul 10, 2024
ac88b64
Merge remote-tracking branch 'upstream/branch-24.08' into enh/write-c…
elstehle Jul 12, 2024
3d666eb
docs fix
elstehle Jul 17, 2024
2caaf8b
Merge remote-tracking branch 'upstream/branch-24.08' into enh/write-c…
elstehle Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions cpp/benchmarks/io/fst.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ void BM_FST_JSON(nvbench::state& state)
auto parser = cudf::io::fst::detail::make_fst(
cudf::io::fst::detail::make_symbol_group_lut(pda_sgs),
cudf::io::fst::detail::make_transition_table(pda_state_tt),
cudf::io::fst::detail::make_translation_table<max_translation_table_size>(pda_out_tt),
cudf::io::fst::detail::make_translation_table<max_translation_table_size,
min_translated_out,
max_translated_out>(pda_out_tt),
stream);

state.set_cuda_stream(nvbench::make_cuda_stream_view(stream.value()));
Expand Down Expand Up @@ -134,7 +136,9 @@ void BM_FST_JSON_no_outidx(nvbench::state& state)
auto parser = cudf::io::fst::detail::make_fst(
cudf::io::fst::detail::make_symbol_group_lut(pda_sgs),
cudf::io::fst::detail::make_transition_table(pda_state_tt),
cudf::io::fst::detail::make_translation_table<max_translation_table_size>(pda_out_tt),
cudf::io::fst::detail::make_translation_table<max_translation_table_size,
min_translated_out,
max_translated_out>(pda_out_tt),
stream);

state.set_cuda_stream(nvbench::make_cuda_stream_view(stream.value()));
Expand Down Expand Up @@ -171,7 +175,9 @@ void BM_FST_JSON_no_out(nvbench::state& state)
auto parser = cudf::io::fst::detail::make_fst(
cudf::io::fst::detail::make_symbol_group_lut(pda_sgs),
cudf::io::fst::detail::make_transition_table(pda_state_tt),
cudf::io::fst::detail::make_translation_table<max_translation_table_size>(pda_out_tt),
cudf::io::fst::detail::make_translation_table<max_translation_table_size,
min_translated_out,
max_translated_out>(pda_out_tt),
stream);

state.set_cuda_stream(nvbench::make_cuda_stream_view(stream.value()));
Expand Down Expand Up @@ -209,7 +215,9 @@ void BM_FST_JSON_no_str(nvbench::state& state)
auto parser = cudf::io::fst::detail::make_fst(
cudf::io::fst::detail::make_symbol_group_lut(pda_sgs),
cudf::io::fst::detail::make_transition_table(pda_state_tt),
cudf::io::fst::detail::make_translation_table<max_translation_table_size>(pda_out_tt),
cudf::io::fst::detail::make_translation_table<max_translation_table_size,
min_translated_out,
max_translated_out>(pda_out_tt),
stream);

state.set_cuda_stream(nvbench::make_cuda_stream_view(stream.value()));
Expand Down
Loading
Loading